Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for tm_ funcalls in stack attributes #451

Merged
merged 17 commits into from
Jul 6, 2022

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Jul 6, 2022

No description provided.

@i4ki i4ki requested a review from katcipis July 6, 2022 14:47
@i4ki i4ki marked this pull request as draft July 6, 2022 14:47
@i4ki i4ki marked this pull request as draft July 6, 2022 14:47
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #451 (122d9c6) into main (b7ca431) will increase coverage by 0.02%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
+ Coverage   70.46%   70.49%   +0.02%     
==========================================
  Files          47       47              
  Lines        8276     8282       +6     
==========================================
+ Hits         5832     5838       +6     
  Misses       2169     2169              
  Partials      275      275              
Flag Coverage Δ
tests 70.49% <89.47%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/sandbox/sandbox.go 86.20% <80.00%> (+0.14%) ⬆️
cmd/terramate/e2etests/hclwrite_utils.go 100.00% <100.00%> (ø)
hcl/hcl.go 89.44% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ca431...122d9c6. Read the comment docs.

@i4ki i4ki marked this pull request as ready for review July 6, 2022 15:07
s := sandbox.New(t)

extDir := s.RootEntry().CreateDir("EXTERNAL")
extFile := extDir.CreateFile("FILE.TXT", "anything")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FILE.TXT made me think about old Windows stuff 🤣

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is the old msdos stuff, everything always showed on uppercase..or something like that 😆

hcl/hcl_stack_test.go Outdated Show resolved Hide resolved
hcl/hcl_stack_test.go Outdated Show resolved Hide resolved
i4ki and others added 2 commits July 6, 2022 17:07
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
@katcipis katcipis self-requested a review July 6, 2022 16:08
Copy link
Contributor

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀 🚀

@i4ki i4ki merged commit 5130e49 into main Jul 6, 2022
@i4ki i4ki deleted the i4k-watch-support-funcalls branch July 6, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants