Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate_hcl: remove origin info from header #710

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

katcipis
Copy link
Contributor

Reason for This Change

We want to avoid triggering stacks on change detection when we just move generate blocks to different files.
This is a breaking change.

Description of Changes

Remove the origin information from the header and update the outdated detection test.

@katcipis katcipis requested a review from i4ki November 14, 2022 12:31
@katcipis katcipis self-assigned this Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 71.24% // Head: 71.24% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (7b0b025) compared to base (a31f9dc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   71.24%   71.24%   -0.01%     
==========================================
  Files          72       72              
  Lines       11529    11525       -4     
==========================================
- Hits         8214     8211       -3     
+ Misses       2982     2981       -1     
  Partials      333      333              
Flag Coverage Δ
tests 71.24% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
generate/genhcl/genhcl.go 91.76% <100.00%> (-0.08%) ⬇️
manager.go 59.56% <0.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@i4ki i4ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@katcipis katcipis merged commit e609f8a into main Nov 14, 2022
@katcipis katcipis deleted the katcipis-generate-hcl-remove-header branch November 14, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants