Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add stack object and improve hcl parser #88

Closed
wants to merge 16 commits into from
Closed

refactor: add stack object and improve hcl parser #88

wants to merge 16 commits into from

Conversation

katcipis
Copy link
Contributor

@katcipis katcipis commented Dec 14, 2021 •
edited
Loading

Code extracted from #58

@katcipis katcipis self-assigned this Dec 14, 2021
@katcipis katcipis requested a review from i4ki December 14, 2021 14:35
@katcipis katcipis marked this pull request as ready for review December 14, 2021 14:35
@i4ki
Copy link
Contributor

i4ki commented Dec 15, 2021

@katcipis I improved a bit and implemented stack block parsing and init, but still missing detection if the stack is a leaf directory.

@i4ki
Copy link
Contributor

i4ki commented Dec 15, 2021

I just added leaf dir detection for stacks.

@i4ki
Copy link
Contributor

i4ki commented Dec 15, 2021

I can't review my own code, it's your branch haha

@i4ki i4ki closed this Dec 15, 2021
@katcipis katcipis deleted the katcipis-refactor-stacks branch April 28, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i4ki i4ki Awaiting requested review from i4ki

Assignees

@katcipis katcipis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@katcipis @i4ki