Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package for fast-syntax-highlighting for ZSH #1037

Open
wants to merge 11 commits into
base: f40
Choose a base branch
from
Open

Add package for fast-syntax-highlighting for ZSH #1037

wants to merge 11 commits into from

Conversation

VehementHam
Copy link

No description provided.

@VehementHam VehementHam mentioned this pull request Apr 2, 2024
Open
@madonuko madonuko enabled auto-merge (squash) April 2, 2024 15:37
madonuko
madonuko reviewed Apr 2, 2024
View reviewed changes
anda/tools/F-Sy-H/anda.hcl Outdated Show resolved Hide resolved
auto-merge was automatically disabled April 3, 2024 14:57

Head branch was pushed to by a user without write access

VehementHam and others added 2 commits April 3, 2024 17:52
@VehementHam @madonuko
Update anda/tools/F-Sy-H/anda.hcl
cfdcff2 
Co-authored-by: madomado <madonuko@outlook.com>
Signed-off-by: VehementHam <75701545+VehementHam@users.noreply.github.com>
@VehementHam @madonuko
Update anda/tools/F-Sy-H/anda.hcl
d6fb9aa 
Co-authored-by: madomado <madonuko@outlook.com>
Signed-off-by: VehementHam <75701545+VehementHam@users.noreply.github.com>
@madonuko madonuko enabled auto-merge (squash) April 4, 2024 03:13
@madonuko
Copy link
Member

madonuko commented Apr 4, 2024

I think you applied the suggestion twice…

@madonuko madonuko disabled auto-merge April 4, 2024 03:14
@madonuko
rm dup suggestion
099d709 
Signed-off-by: madomado <madonuko@outlook.com>
@madonuko madonuko requested a review from lleyton April 5, 2024 13:03
@madonuko madonuko enabled auto-merge (squash) April 5, 2024 13:03
lleyton
lleyton requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@lleyton lleyton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Also, maybe we should require zsh?

@VehementHam
Copy link
Author

image

Also, maybe we should require zsh?

Not sure. It was in the .spec originally, but I think it was removed by the recommendation of another member.

@VehementHam
Copy link
Author

VehementHam commented Apr 18, 2024 •
edited

Feel free to make a commit.

@VehementHam
Copy link
Author

image

Also, maybe we should require zsh?

How are you testing this?

auto-merge was automatically disabled May 9, 2024 19:40

Head branch was pushed to by a user without write access

@VehementHam VehementHam changed the title Add package for F-Sy-H ZSH syntax highlighting Add package for fast-syntax ZSH syntax highlighting May 9, 2024
@VehementHam VehementHam changed the title Add package for fast-syntax ZSH syntax highlighting Add package for fast-syntax-highlighting for ZSH May 9, 2024
@lleyton
Copy link
Member

lleyton commented May 14, 2024 •
edited

image
Also, maybe we should require zsh?

How are you testing this?

Under the checks tab, GHA artifacts containing the RPMs are uploaded there

@VehementHam
Copy link
Author

Okay, well I did not fix to fast-syntax-highlighting in every file yet, so that is a problem.

@VehementHam
Update update.rhai
b238971 
Signed-off-by: VehementHam <75701545+VehementHam@users.noreply.github.com>
@VehementHam
Update anda.hcl
41b2418 
Signed-off-by: VehementHam <75701545+VehementHam@users.noreply.github.com>
@VehementHam
Copy link
Author

Okay, well I did not fix to fast-syntax-highlighting in every file yet, so that is a problem.

Fixed that issue

lleyton
lleyton reviewed May 15, 2024
View reviewed changes
anda/tools/fast-syntax-highlighting/fast-syntax-highlighting.spec Outdated
@@ -0,0 +1,27 @@
Name: fast-syntax-highlighting
Version: 1.67
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.67 doesn't seem to be a valid version, which is causing the build to fail

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the latest is 1.55 I think

you'll also need to use gh_tag instead in update.rhai

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think I corrected the version

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll also need to use gh_tag instead in update.rhai

Think I did this to

@VehementHam
Correct Version
0cf7312 
Signed-off-by: VehementHam <75701545+VehementHam@users.noreply.github.com>
@VehementHam
Update update.rhai
17bc87d 
Signed-off-by: VehementHam <75701545+VehementHam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lleyton lleyton lleyton requested changes

@madonuko madonuko madonuko left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VehementHam @madonuko @lleyton