Skip to content

Commit

Permalink
Remove Parent tests/impls/reqs (#1565)
Browse files Browse the repository at this point in the history
  • Loading branch information
Ashlita6 committed Jan 2, 2024
1 parent 78042b2 commit 24e36fe
Show file tree
Hide file tree
Showing 8 changed files with 30 additions and 22 deletions.
4 changes: 4 additions & 0 deletions armi/cases/tests/test_cases.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,10 @@ def test_run(self):
.. test:: There is a generic mechanism to allow simulation runs.
:id: T_ARMI_CASE
:tests: R_ARMI_CASE
.. test:: Test case settings object is created, settings can be edited, and case can run.
:id: T_ARMI_SETTING
:tests: R_ARMI_SETTING
"""
with directoryChangers.TemporaryDirectoryChanger():
cs = settings.Settings(ARMI_RUN_PATH)
Expand Down
8 changes: 4 additions & 4 deletions armi/reactor/composites.py
Original file line number Diff line number Diff line change
Expand Up @@ -2669,7 +2669,7 @@ class Composite(ArmiObject):
reactors.
.. impl:: Composites are a physical part of the reactor in a hierarchical data model.
:id: I_ARMI_CMP
:id: I_ARMI_CMP0
:implements: R_ARMI_CMP
"""

Expand Down Expand Up @@ -2776,9 +2776,9 @@ def getChildren(
"""
Return the children objects of this composite.
.. impl:: Composites have children, in the hierarchical data model.
:id: I_ARMI_CMP_CHILDREN
:implements: R_ARMI_CMP_CHILDREN
.. impl:: Composites have children in the hierarchical data model.
:id: I_ARMI_CMP1
:implements: R_ARMI_CMP
Parameters
----------
Expand Down
4 changes: 0 additions & 4 deletions armi/reactor/converters/axialExpansionChanger.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,6 @@ class AxialExpansionChanger:
"""
Axially expand or contract assemblies or an entire core.
.. impl:: Performing axial expansion on solid components within a compatible ARMI assembly.
:id: I_ARMI_AXIAL_EXP
:implements: R_ARMI_AXIAL_EXP
.. impl:: Preserve the total height of an ARMI assembly, during expansion.
:id: I_ARMI_ASSEM_HEIGHT_PRES
:implements: R_ARMI_ASSEM_HEIGHT_PRES
Expand Down
4 changes: 0 additions & 4 deletions armi/reactor/reactors.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,6 @@ class Reactor(composites.Composite):
.. impl:: The user-specified reactor.
:id: I_ARMI_R
:implements: R_ARMI_R
.. impl:: The reactor includes a core and a spent fuel pool.
:id: I_ARMI_R_CHILDREN
:implements: R_ARMI_R_CHILDREN
"""

pDefs = reactorParameters.defineReactorParameters()
Expand Down
16 changes: 14 additions & 2 deletions armi/reactor/tests/test_components.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ def getCircleFuelDict(self):
)

def test_factory(self):
"""Creating and verifying void and fuel components.
.. test:: Example void and fuel components are initialized.
:id: T_ARMI_COMP_DEF0
:tests: R_ARMI_COMP_DEF
"""
voidAttrs = self.getCircleVoidDict()
voidComp = components.factory(voidAttrs.pop("shape"), [], voidAttrs)
fuelAttrs = self.getCircleFuelDict()
Expand All @@ -85,6 +91,12 @@ def test_factory(self):
self.assertIsInstance(fuelComp.material, materials.UZr)

def test_componentInitializationAndDuplication(self):
"""Initialize and duplicate a component, veifying the parameters.
.. test:: Verify the parameters of an initialized component.
:id: T_ARMI_COMP_DEF1
:tests: R_ARMI_COMP_DEF
"""
# populate the class/signature dict, and create a basis attrs
attrs = self.getCircleVoidDict()
del attrs["shape"]
Expand Down Expand Up @@ -186,7 +198,7 @@ def test_setNumberDensity(self):
"""Test setting a single number density.
.. test:: Users can set Component number density.
:id: T_ARMI_COMP_NUCLIDE_FRASCS0
:id: T_ARMI_COMP_NUCLIDE_FRACS0
:tests: R_ARMI_COMP_NUCLIDE_FRACS
"""
component = self.component
Expand All @@ -198,7 +210,7 @@ def test_setNumberDensities(self):
"""Test setting multiple number densities.
.. test:: Users can set Component number densities.
:id: T_ARMI_COMP_NUCLIDE_FRASCS1
:id: T_ARMI_COMP_NUCLIDE_FRACS1
:tests: R_ARMI_COMP_NUCLIDE_FRACS
"""
component = self.component
Expand Down
8 changes: 4 additions & 4 deletions armi/reactor/tests/test_composites.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ def test_composite(self):
"""Test basic Composite things.
.. test:: Composites are part of a hierarchical model.
:id: T_ARMI_CMP_CHILDREN0
:tests: R_ARMI_CMP_CHILDREN
:id: T_ARMI_CMP0
:tests: R_ARMI_CMP
"""
container = self.container

Expand All @@ -133,8 +133,8 @@ def test_getChildren(self):
"""Test the get children method.
.. test:: Composites are part of a hierarchical model.
:id: T_ARMI_CMP_CHILDREN1
:tests: R_ARMI_CMP_CHILDREN
:id: T_ARMI_CMP1
:tests: R_ARMI_CMP
"""
# There are 5 leaves and 1 composite in container. The composite has one leaf.
firstGen = self.container.getChildren()
Expand Down
4 changes: 0 additions & 4 deletions armi/reactor/tests/test_reactors.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,6 @@ def test_coreSfp(self):
.. test:: The reactor object is a composite.
:id: T_ARMI_R
:tests: R_ARMI_R
.. test:: The reactor object includes a core and an SFP.
:id: T_ARMI_R_CHILDREN
:tests: R_ARMI_R_CHILDREN
"""
self.assertTrue(isinstance(self.r.core, reactors.Core))
self.assertTrue(isinstance(self.r.sfp, SpentFuelPool))
Expand Down
4 changes: 4 additions & 0 deletions armi/tests/test_plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ def test_defineFlags(self):
.. test:: Define a new, unique flag through the plugin pathway.
:id: T_ARMI_FLAG_EXTEND1
:tests: R_ARMI_FLAG_EXTEND
.. test:: Load a plugin into an app and show it is loaded.
:id: T_ARMI_PLUGIN_REGISTER
:tests: R_ARMI_PLUGIN
"""
app = getApp()

Expand Down

0 comments on commit 24e36fe

Please sign in to comment.