-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force Parameters to have descriptions #1348
Comments
@keckler FYI @sombrereau @drewj-usnctech Would this be a problem for either of you? |
I like the idea of enforcing that these are set. Could be a breaking change, but probably a good one? Maybe we can start implementing warnings to fix before we enforce so that folks have a chance to change? I also like the idea of enforcing locations would be good too. |
On board for this. Parameters should have descriptions. I think setting Maybe a non-None field like |
I am changing this ticket to only FORCE Parameter descriptions, not units. And I already have a armi/armi/reactor/parameters/parameterDefinitions.py Lines 255 to 259 in 59388d2
The plan is:
Estimated time to close this ticket: 2 months (of waiting). |
I have put this on the ARMI Really, the change in ARMI is no work at all. The time here will be spent on testing downstream projects to see if they will break. |
When constructing a
Parameter
object, we already have multiple checks to ensure theParameter
is valid:armi/armi/reactor/parameters/parameterDefinitions.py
Lines 250 to 253 in 59388d2
Why not add some to ensure there is a valid
description
field? I want to say the same forunits
, but many parameters are unitless, so we would have to change "unitless" to be a non-empty string.The text was updated successfully, but these errors were encountered: