Filling in empty Parameter units and descriptions

[john-science]

What is the change?

We are finally filling in all the missing values in the units and description fields of our ARMI Parameters.

I have also completely removed 16 Parameters, because they are unused:

• avgFuelTemp
• avgTempRef
• baseBu
• basePBu
• bu
• currentPercentExpanded
• maxdilationTotal
• maxresidence
• Torus geometry:
  • azimuthal_differential
  • height
  • inner_axial
  • inner_minor_radius
  • inner_phi
  • inner_radius
  • inner_theta
  • major_radius
  • outer_axial
  • outer_minor_radius
  • outer_phi
  • outer_radius
  • outer_theta
  • radius_differential
  • reference_volume

NOTE: I should note all the above "torus" parameters were removed, and in the end we removed the entire Torus geometry. It was entirely unused, and in the process of reviewing these Parameters I found a few bugs in our Torus geometry.

NOTE: As part of #1348, we are also adding a DeprecationWarning that at some point Parameters will demand non-empty descriptions.

Why is the change being made?

What is the good of having "units" and "description" fields on important and heavily-used ARMI Parameters if they are left blank?

These should have been filled in years ago.

---

Checklist

• This PR has only one purpose or idea.
• Tests have been added/updated to verify that the new/changed code works.

• The code style follows good practices.
• The commit message(s) follow good practices.

• The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
• The documentation is still up-to-date in the doc folder.
• The dependencies are still up-to-date in setup.py.

[john-science]

Code coverage went down because I mostly deleted code. That's fine.

[keckler]

Some various comments/musings.

I also want to highlight that the Torus component shape has been removed entirely by this PR. From my read of the PR description, I was expecting that just some parameters of the Torus were removed. I don't have a complaint about removing Torus, because it appears to be possible to do the same things via RadialSegment.

[keckler]

Unrelated to your changes, but this parameter can almost certainly be removed.

[john-science]

That will require a ticket though, because the name of this parameter is so generic that it makes it hard to grep through downstream repos to find it.

It might be easier to just remove the Parameter, and see if anything breaks downstream.

[keckler]

A handful of small suggestions, but otherwise looks good.

Thanks for your work on this, it's an obvious improvement to the codebase!

[john-science]

A handful of small suggestions, but otherwise looks good.

Thanks for your work on this, it's an obvious improvement to the codebase!

Thanks, Chris!

The original goal of this PR was just to fix missing/wrong units/descriptions.

I see what you're doing with the units there, and I think at some point I will either do that with ALL the units, or we will use pint to do that.

But this PR is already so hefty, I'll leave that for the next one (and #352).