material modifications table in docs is missing options

[keckler]

This table lists all the material modifications available for each of the material classes that have them:

Some of the entries in this table are missing options. For instance, all subclasses of material.FuelMaterial should have the options class1_custom_isotopics, class2_custom_isotopics, class1_wt_frac. Right now those are not listed for many of the fuel materials because we only search through the applyInputParams method at the lowest level of the MRO for each of the materials.

This can be changed by editing the code snippet here:

armi/doc/user/inputs/blueprints.rst

Lines 393 to 414 in d3afb25

	.. exec::
	from armi.materials import Material
	from tabulate import tabulate
	data = []
	for m in Material.__subclasses__():
	numArgs = m.applyInputParams.__code__.co_argcount
	if numArgs > 1:
	modNames = m.applyInputParams.__code__.co_varnames[1:numArgs]
	data.append((m.__name__, ', '.join(modNames)))
	for subM in m.__subclasses__():
	num = subM.applyInputParams.__code__.co_argcount
	if num > 1:
	mods = subM.applyInputParams.__code__.co_varnames[1:num]
	data.append((subM.__name__, ', '.join(mods)))
	data.sort(key=lambda t: t[0])
	return tabulate(headers=('Material Name', 'Available Modifications'),
	tabular_data=data, tablefmt='rst')

We did some work on this same table back in #431 to make all of the relevant materials show up. We should have caught this issue at that time as well, but I wasn't as familiar with the material classes back then.

[keckler]

Possibly related, I can't tell...

This variable defined in the materials package is never used anywhere in the framework nor in our internal applications. I think it is defunct?

armi/armi/materials/__init__.py

Lines 97 to 105 in d3afb25

	# the co_varnames attribute contains arguments and then locals so we must restrict it to just the arguments.
	AVAILABLE_MODIFICATION_NAMES = {
	name
	for subclass in dynamicImporter.getEntireFamilyTree(Material)
	for name in subclass.applyInputParams.__code__.co_varnames[
	: subclass.applyInputParams.__code__.co_argcount
	]
	}
	AVAILABLE_MODIFICATION_NAMES.remove("self")

[john-science]

This variable defined in the materials package is never used anywhere in the framework nor in our internal applications. I think it is defunct?

I added this to a cleanup PR: #1439

[keckler]

Also worthy to mention that a couple materials are in this table twice somehow?

[john-science]

Also worthy to mention that a couple materials are in this table twice somehow?

UraniumOxide and ThoriumOxide each appear twice.