Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up material modification table #1441

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

john-science
Copy link
Member

What is the change?

I improved the "materials modification" table in the blueprints docs:

  • I removed duplicate entries.
  • I added any modifications from the superclasses.

The contents of the table are now:

('B4C', 'B10_wt_frac, theoretical_density, TD_frac')
('FuelMaterial', 'class1_custom_isotopics, class2_custom_isotopics, class1_wt_frac, customIsotopics')
('Lithium', 'LI_wt_frac, LI6_wt_frac')
('Sulfur', 'sulfur_density_frac, TD_frac')
('ThU', 'U233_wt_frac, class1_custom_isotopics, class2_custom_isotopics, class1_wt_frac, customIsotopics')
('Thorium', 'class1_custom_isotopics, class2_custom_isotopics, class1_wt_frac, customIsotopics, class1_custom_isotopics, class2_custom_isotopics, class1_wt_frac, customIsotopics')
('ThoriumOxide', 'TD_frac, class1_custom_isotopics, class1_wt_frac, class2_custom_isotopics, customIsotopics')
('UThZr', 'U235_wt_frac, ZR_wt_frac, class1_custom_isotopics, class2_custom_isotopics, class1_wt_frac, customIsotopics')
('UZr', 'U235_wt_frac, ZR_wt_frac, class1_custom_isotopics, class2_custom_isotopics, class1_wt_frac, customIsotopics')
('Uranium', 'U235_wt_frac, TD_frac, class1_custom_isotopics, class2_custom_isotopics, class1_wt_frac, customIsotopics')
('UraniumOxide', 'TD_frac, U235_wt_frac, class1_custom_isotopics, class1_wt_frac, class2_custom_isotopics, customIsotopics')

Why is the change being made?

To close #1437


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added documentation Improvements or additions to documentation cleanup Code/comment cleanup: Low Priority labels Oct 18, 2023
@john-science john-science merged commit 85d4f6e into main Oct 19, 2023
23 checks passed
@john-science john-science deleted the cleaning_up_mat_mod_table branch October 19, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

material modifications table in docs is missing options
2 participants