Dead parameter rotationDegreesCCW in Block.coords()

[keckler]

If one specifies the rotationDegreesCCW parameter to coords(), it will either result in an error or do nothing with it:

armi/armi/reactor/blocks.py

Lines 597 to 607 in 4f55d94

	def coords(self, rotationDegreesCCW=0.0):
	"""
	Returns the coordinates of the block.
	.. impl:: Coordinates of a block are queryable.
	:id: I_ARMI_BLOCK_POSI1
	:implements: R_ARMI_BLOCK_POSI
	"""
	if rotationDegreesCCW:
	raise NotImplementedError("Cannot get coordinates with rotation.")
	return self.spatialLocator.getGlobalCoordinates()

armi/armi/reactor/blocks.py

Lines 1620 to 1634 in 4f55d94

	def coords(self, rotationDegreesCCW=0.0):
	"""
	Returns the coordinates of the block.
	.. impl:: Coordinates of a block are queryable.
	:id: I_ARMI_BLOCK_POSI2
	:implements: R_ARMI_BLOCK_POSI
	"""
	x, y, _z = self.spatialLocator.getGlobalCoordinates()
	x += self.p.displacementX * 100.0
	y += self.p.displacementY * 100.0
	return (
	round(x, units.FLOAT_DIMENSION_DECIMALS),
	round(y, units.FLOAT_DIMENSION_DECIMALS),
	)

I can't find any use of this parameter in any repos that I have access to. I'm not even sure what it would mean for the rotation of a block to impact its location, assuming that orientation is about the centroid of the block.

Extremely low priority, but just pointing it out.

[john-science]

I agree with Chris' assessment. This parameter looks like it should be removable from both methods.

It's possible that someone is passing unused values into one of those methods, positionally. But (a) unit tests would catch that, and (b) we'd want to know if people were trying to use this defunct parameter anyway.