Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused Block.coords argument rotationDegreesCCW #1651

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

john-science
Copy link
Member

@john-science john-science commented Feb 20, 2024

What is the change?

Removed an unused argument (rotationDegreesCCW) from Block.coords() and its subclasses.

Why is the change being made?

Close #1518


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • If any requirements were affected, mention it in the release notes.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Feb 20, 2024
Copy link
Member

@keckler keckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this should be merged after #1650 due to the release notes in this PR including the changes from that PR.

@john-science
Copy link
Member Author

Note that this should be merged after #1650 due to the release notes in this PR including the changes from that PR.

Yeah, I don't mind merge conflicts. I'll handle them.

Thanks!

@john-science john-science merged commit cfbc7f6 into main Feb 22, 2024
21 checks passed
@john-science john-science deleted the rm_rotationDegreesCCW branch February 22, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead parameter rotationDegreesCCW in Block.coords()
2 participants