Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flux reconstruction parameters. #1002

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

mgjarrett
Copy link
Contributor

@mgjarrett mgjarrett commented Nov 30, 2022

Description

We are removing some parameters from ARMI, because they are too design specific to the one code that uses them:

  • axialMgFluxReconCoeff
  • axialMgFluxProfileNeutron
  • axialMgFluxProfileGamma
  • radialMgFluxProfile
  • radialMgFluxProfileAdj
  • radialMgFluxProfileNeutron
  • radialMgFluxProfileNeutronAdj
  • radialMgFluxProfileGamma

But we are also adding back in some parameters that were recently moved out of ARMI:

  • pointsEdgeFastFluxFr
  • pointsEdgeDpa
  • pointsEdgeDpaRate

Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@keckler keckler mentioned this pull request Nov 30, 2022
7 tasks
@john-science
Copy link
Member

I believe these parameters are more widely used in the ecosystem, and should remain in ARMI:

  • pointsCornerDpa
  • pointsCornerDpaRate
  • pointsCornerFastFluxFr

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Nov 30, 2022
@john-science john-science merged commit 816d080 into terrapower:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants