Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix power after snapshot load #1024

Merged
merged 3 commits into from Dec 15, 2022
Merged

Fix power after snapshot load #1024

merged 3 commits into from Dec 15, 2022

Conversation

onufer
Copy link
Contributor

@onufer onufer commented Dec 14, 2022

Description

Fix a bug where power setting would not be respected during snapshot database load


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@onufer
Copy link
Contributor Author

onufer commented Dec 14, 2022

@john-science , we have no unit tests for the snapshot load at all and its part of db load which is a pretty heavy lift. i think we should rely on internal in-use tests.

@onufer onufer changed the title fix power after snapshot load Fix power after snapshot load Dec 15, 2022
Copy link
Member

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the cause of the problem. But the solution proposed seems fine, if the problem exists.

@onufer onufer merged commit ce71855 into main Dec 15, 2022
@opotowsky opotowsky deleted the fixPowerOnSnapshotLoad branch July 14, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants