Remove unused HCFcoretype setting #1179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
HCFcoretype
setting is not used anywhere in the framework or in downstream TerraPower projects.Since the only options are
TWR*
, I assume nobody outside of TerraPower is using this setting either.TerraPower TH solvers use an assembly parameter to track hot channel factors:
armi/armi/reactor/assemblyParameters.py
Lines 358 to 366 in 0576560
I assume anybody else wanting to apply hot channel factors would want to use the same assembly parameter, and not this case setting.
Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.