Add MPI action prioritization capability and corresponding settings to lattice phyics #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgjarrett
reviewed
Apr 10, 2023
armi/mpiActions.py
Outdated
| Notes | ||
| ----- | ||
| All exclusive actions will occur first regardless of the priority. | ||
| All non-exclusive actions with be after all exclusive actions regardless of the priority. |
There was a problem hiding this comment.
Suggested change
| All non-exclusive actions with be after all exclusive actions regardless of the priority. | |
| All non-exclusive actions will be after all exclusive actions regardless of the priority. |
mgjarrett
approved these changes
Apr 10, 2023
mgjarrett
added a commit
to mgjarrett/armi
that referenced
this pull request
Apr 12, 2023
john-science
pushed a commit
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The motivation for this PR is that there is no way of prioritizing lattice physics jobs. Since some lattice physics jobs are 0D slowing down and run relatively quick (<5 minutes) and the 1D lattice physics calcs can take much longer (20-30 minutes if the number of isotopes is large), the load balancing could be pretty bad. The goal of the PR was to allow the user to flag some XS calcs to run "exclusive" on a single node. This means that one node would be pulled to the side and dedicated to that single, long-running MC2 job. The nodes that haven't been pulled aside for an "exclusive" job will then work through the rest of the queue one job at a time.
Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.