-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change b.axialExpTargetComponent to block parameter #1256
Conversation
Found an issue with this. Will reopen when ready. |
…d of the component directly
Note to reviewers: The issue was that originally, |
- these are coming back, don't worry!
Coverage failure seems to be coverage spray.... |
Converting to draft while this waits it's turn in line within a downstream ARMI app. |
Description
Downstream analysis identified an issue where the blueprints specified axial expansion target component was unable to be used with database loads (i.e., restarts and snapshot runs). This PR changes the Block class instance variable,
b.axialExpTargetComponent
, to a registered block parameter that gets written to the db.When a standard run to executed, the axial expansion target components for each block are stored as block parameters and written to the DB. When used for a DB load case, they are directly read off of the database.
Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.