-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize material names and class names #1270
Conversation
If we're gonna do this, I welcome you to fix all the broken blueprints files in our benchmark models :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending testing.
I don't think this needed. We ran into this in terrapower-twr a few months ago with T92Depleted vs T92-Depleted-Boron. The blueprints use the class name not the name field. |
Well I'll be darned, you're right. Forget my snarky comment! |
Two unit tests failing:
and
|
@john-science Two unit tests are updated! Sorry I didn't catch those locally |
@alexhjames / @john-science This broke a few of my internal unittests because of name changes to Uranium Oxide and Zirconium. No big deal, but I think we need to do a better job communicating these kinds of changes ... or maybe on my end listening for these kinds of changes. |
* main: (23 commits) block converters preserve flags (terrapower#1271) Fixed float decimals v3 (terrapower#1283) Fixed string format error for snapshots (terrapower#1277) Pinning the versions of yamlize and ruamel (terrapower#1281) Releasing v0.2.7 (terrapower#1276) Creating verisons setting section (terrapower#1274) Adding to GlobalFluxOptions docstring (terrapower#1273) Harmonize material names and class names (terrapower#1270) Removing Component.getMassDensity (terrapower#1266) Cleaning up language for our versioning rules (terrapower#1175) Fixing the Settings Report in the Docs (terrapower#1264) Fixing getTemperatureAtDensity to use non-pseduo density (terrapower#1262) Fixing settings report docs from terrapower#1207 (terrapower#1263) Update test_components.py (terrapower#1261) Update gamma Uniform Mesh Converter (terrapower#1213) Updating way that settings report defaults are printed (terrapower#1207) Fixing UserPlugins.defineFlag (terrapower#1241) quick bug fix for PR 1239 (terrapower#1260) New Option to Control Lattice Physics Update Frequency (terrapower#1239) Fix a bug in database compare. (terrapower#1258) ...
Description
For
materials.resolveMaterialClassByName()
to function,material.name
and the class name should be the same. This PR ensures that is true for all materials.No testing was added as the name field on the material isn't really something to be tested.
Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.