Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding implementation information to the materials package #1587

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

john-science
Copy link
Member

What is the change?

Adding implementation information to the materials package

Why is the change being made?

This is part of on-going QA work.


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • If any requirements were affected, mention it in the release notes.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the documentation Improvements or additions to documentation label Jan 19, 2024
@bsculac bsculac self-requested a review January 22, 2024 17:39
armi/materials/__init__.py Outdated Show resolved Hide resolved
armi/materials/__init__.py Outdated Show resolved Hide resolved
armi/materials/material.py Outdated Show resolved Hide resolved
armi/materials/material.py Outdated Show resolved Hide resolved
armi/materials/material.py Outdated Show resolved Hide resolved
Copy link
Contributor

@bsculac bsculac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments made, ready for originator review.

john-science and others added 3 commits January 22, 2024 10:29
Co-authored-by: bsculac <102382931+bsculac@users.noreply.github.com>
Copy link
Contributor

@bsculac bsculac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Groovy

@john-science john-science merged commit 4d45672 into main Jan 22, 2024
21 checks passed
@john-science john-science deleted the doc_materials_impls branch January 22, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants