Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details for nuclearDataIO impl tags #1605

Merged
merged 9 commits into from
Jan 25, 2024
Merged

Conversation

zachmprince
Copy link
Collaborator

@zachmprince zachmprince commented Jan 23, 2024

What is the change?

Adding details for nuclearDataIO impl tags. This was pretty difficult for me since I am horridly unfamiliar with the file formats, but I did my best from reading docstrings. pmatrx.py is one that I feel especially bad about since there are no docstrings in the module and information online was extremely sparse.

Why is the change being made?

Ongoing SQA effort.


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • If any requirements were affected, mention it in the release notes.
  • The dependencies are still up-to-date in pyproject.toml.

@zachmprince zachmprince added the documentation Improvements or additions to documentation label Jan 23, 2024
armi/nuclearDataIO/cccc/dif3d.py Show resolved Hide resolved
armi/nuclearDataIO/xsCollections.py Show resolved Hide resolved
armi/nuclearDataIO/cccc/pmatrx.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/cccc/dlayxs.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/cccc/dlayxs.py Show resolved Hide resolved
armi/nuclearDataIO/cccc/dlayxs.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/cccc/dlayxs.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/cccc/geodst.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/cccc/isotxs.py Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

armi/nuclearDataIO/cccc/cccc.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/cccc/cccc.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/cccc/cccc.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/cccc/gamiso.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/cccc/gamiso.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/xsCollections.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/xsCollections.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/xsCollections.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/xsCollections.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/xsCollections.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Nebbychadnezzar Nebbychadnezzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment left.

armi/nuclearDataIO/cccc/gamiso.py Outdated Show resolved Hide resolved
armi/nuclearDataIO/xsCollections.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Nebbychadnezzar Nebbychadnezzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! :D

Comment on lines +813 to +815
.. math::

\Sigma_{g} = \sum_{n} N_n \sigma_{n,g}\nu_n \quad g=1,...,G
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is going to work now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@zachmprince zachmprince merged commit 17a2afe into terrapower:main Jan 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants