Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused method HexGrid.allPositionsInThird #1655

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

john-science
Copy link
Member

What is the change?

Removing an unused method.

Why is the change being made?

This method has never been used by ARMI or any downstream project (except one) in the last 4-5 years. So I am moving it to the downstream project.

I find this method to be a bit too specific to have in the HexGrid class.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Feb 29, 2024
@john-science
Copy link
Member Author

@opotowsky I have opened a parallel PR downstream, that you should see.

Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy :-)

@john-science john-science merged commit bb6ba5c into main Mar 4, 2024
15 checks passed
@john-science john-science deleted the rm_allPositionsInThird branch March 4, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants