Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing old Database2 converters #1658

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Removing old Database2 converters #1658

merged 3 commits into from
Mar 11, 2024

Conversation

john-science
Copy link
Member

@john-science john-science commented Mar 5, 2024

What is the change?

Removing references to versions of the database prior to Database3:

  • armi.bookkeeping.db.convertDatabase()
  • armi.cli.database.ConvertDB

Why is the change being made?

This version of the ARMI Database was introduced more than 4.5 years ago, and these tools were introduced to help people make the transition. The transition is over.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Mar 5, 2024
@john-science
Copy link
Member Author

@drewj-usnctech I wanted to check that this change won't affect you. I can't imagine it will, but just to be sure.

Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love a good delete-only PR :-)

@john-science john-science merged commit c07fe4f into main Mar 11, 2024
21 checks passed
@john-science john-science deleted the rm_old_db_refs branch March 11, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants