Adding a little code coverage to key Assembly methods

[john-science]

What is the change?

Here I add a little code coverage to three Assembly methods:

• Assembly.add()
• Assembly.getArea()
• Assembly.getDim()

Also, Assembly.add() had a couple lines of broken code that I removed.

Why is the change being made?

This was a request. And these are important methods.

Extra Note

I would just like to document somewhere that I think the Assembly.getArea() method is properly insane. When an Assembly has no children/Blocks, this method returns a "default area" of 1.0. Surely that should be an error? Or it should return None. Or it should return 0.0. Returning a valid numerical value just seems crazy.

Thoughts?

---

Checklist

• This PR has only one purpose or idea.
• Tests have been added/updated to verify any new/changed code.

• The code style follows good practices.
• The commit message(s) follow good practices.

• The release notes have been updated if necessary.
• The documentation is still up-to-date in the doc folder.
• The dependencies are still up-to-date in pyproject.toml.

[albeanth]

the precision of this can be increased. in my testing you can even swap it with a self.assertEqual(cur, ref)

[albeanth]

When an Assembly has no children/Blocks, this method returns a "default area" of 1.0. Surely that should be an error? Or it should return None. Or it should return 0.0. Returning a valid numerical value just seems crazy.

Yeah I agree. It's odd. If you make the change, do a lot of other things break?

@ntouran @jakehader any historical significance here?