Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unused parameter rdIterNum #1704

Merged
merged 3 commits into from
May 20, 2024
Merged

Removing unused parameter rdIterNum #1704

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
571de24
Removing unused parameter rdIterNum
john-science May 16, 2024
22aeaf0
Adding release note
john-science May 16, 2024
4e4caae
Merge branch 'main' into rm_rdIterNum
john-science May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions armi/reactor/reactorParameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,6 @@
def defineReactorParameters():
pDefs = parameters.ParameterDefinitionCollection()

pDefs.add(
parameters.Parameter(
"rdIterNum",
units=units.UNITLESS,
description="Integer number of region-density equilibrium iterations",
location=ParamLocation.AVERAGE,
saveToDB=True,
default=parameters.NoDefault,
setter=parameters.NoDefault,
categories=set(),
)
)

with pDefs.createBuilder(location=ParamLocation.AVERAGE, default=0.0) as pb:
pb.defParam(
"cycle",
Expand Down
1 change: 1 addition & 0 deletions doc/release/0.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ API Changes
* Moving ``ArmiObject.getFissionEnergyGenerationConstants`` to ``Block``.
* Moving ``ArmiObject.getCaptureEnergyGenerationConstants`` to ``Block``.
#. Removing the parameeters ``outsideFuelRing`` and ``outsideFuelRingFluxFr``. (`PR#1700 <https://github.com/terrapower/armi/pull/1700>`_)
#. Removing the parameeter ``rdIterNum``. (`PR#1704 <https://github.com/terrapower/armi/pull/1704>`_)
#. TBD

Bug Fixes
Expand Down
Loading