Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the setting doOrificedTH #1706

Merged
merged 2 commits into from
May 16, 2024
Merged

Removing the setting doOrificedTH #1706

merged 2 commits into from
May 16, 2024

Conversation

john-science
Copy link
Member

What is the change?

Removed the setting doOrificiedTH

Why is the change being made?

There were two major reasons for this:

  1. This setting is not used in ARMI.
  2. It's perhaps too specific to SFRs and not generally useful enough to a broader reactor design audience.

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label May 16, 2024
@john-science
Copy link
Member Author

@andfranklin FYI

Copy link

@andfranklin andfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @john-science

@andfranklin andfranklin merged commit bc50e27 into main May 16, 2024
15 checks passed
@andfranklin andfranklin deleted the rm_doOrificiedTH branch May 16, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants