Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding code coverage to FH & GlobalFluxInt #1732

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Adding code coverage to FH & GlobalFluxInt #1732

merged 3 commits into from
Jun 17, 2024

Conversation

john-science
Copy link
Member

What is the change?

Just adding a few unit tests to the FuelHandler and the GlobalFluxInterface.

Why is the change being made?

I found a few methods with no code coverage, and I am trying to bump the ARMI code coverage over 90%.

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the testing Related to tests label Jun 16, 2024
opotowsky
opotowsky approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@john-science john-science merged commit 8ab9099 into terrapower:main Jun 17, 2024
12 checks passed
@john-science john-science deleted the code_cov_weekend branch June 17, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opotowsky opotowsky opotowsky approved these changes

Assignees
No one assigned
Labels
testing Related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@john-science @opotowsky