Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code coverage to FIXSRC code #1742

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Adding code coverage to FIXSRC code #1742

merged 2 commits into from
Jun 21, 2024

Conversation

john-science
Copy link
Member

What is the change?

Adding code coverage to FIXSRC code

Why is the change being made?

The DIF3D file format is important, and we have never had any unit tests for it.

Thanks to Aaron, for giving me the reference material I needed to understand the code.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

Copy link
Member

@albeanth albeanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, is the code here a complete feature? Or does it need more to actually do something useful? Specifically the fixsrc.py file.

@john-science
Copy link
Member Author

Just curious, is the code here a complete feature? Or does it need more to actually do something useful? Specifically the fixsrc.py file.

The actual code ARMI has to read and write FIXSRC files appears to be fully functional. Aaron gave me some test files (that are WAY too big to commit to the repo), and I was able to test code to my heart's content. But this isn't surprising, considering we actually used this code to drive DIF3D for years.

@john-science john-science merged commit 1890758 into main Jun 21, 2024
23 checks passed
@john-science john-science deleted the fixsrc_work branch June 21, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants