Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tutorial for parameter sweeps #25

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Add tutorial for parameter sweeps #25

merged 2 commits into from
Feb 3, 2020

Conversation

ntouran
Copy link
Member

@ntouran ntouran commented Feb 3, 2020

No description provided.

@ntouran ntouran requested a review from youngmit February 3, 2020 22:05
youngmit
youngmit suggested changes Feb 3, 2020
View reviewed changes
armi/cases/case.py Outdated Show resolved Hide resolved
armi/cases/case.py Outdated Show resolved Hide resolved
armi/tests/tutorials/param_sweep.ipynb Outdated Show resolved Hide resolved
armi/tests/tutorials/param_sweep.ipynb Outdated Show resolved Hide resolved
armi/tests/tutorials/param_sweep.ipynb Outdated Show resolved Hide resolved
armi/tests/tutorials/param_sweep.ipynb Outdated
"source": [
"To submit this suite to a computer cluster, one would run a command simliar to ``python -m tparmi submit-suite`` from the ``case-suite`` folder. \n",
"\n",
".. note:: This requires a compatible HPC plugin for your HPC environment in your application."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a bit confusing to a user that's never seen our plugin before. Maybe provide more context, or simply recommend "submitting many ARMI run commands using whichever job queuing system is available in your HPC environment."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point.

armi/tests/tutorials/param_sweep.ipynb Outdated
"metadata": {},
"source": [
"## Modifying the reactor design\n",
"Modifying settings is one thing, but the real power of parameter sweeps come from programatically perturbing the reactor component designs themselves. We accomplish this by modifying ARMI Blueprint objects as derived from the base input. \n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comes from

@youngmit youngmit merged commit 6c5b86a into terrapower:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngmit youngmit youngmit approved these changes

Assignees

@youngmit youngmit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ntouran @youngmit