Create a generic fuel performance plugin #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the other generic plugins, this will be a central place to put settings, parameters, executers, etc. that are expected to be shared across a variety of fuel performance plugins.
youngmit
suggested changes
Mar 19, 2020
There was a problem hiding this comment.
I am pretty happy with this. I do think it is worth considering comments providing a "where to go from here" for the inevitable LWR fuel performance person the sees this and is surprised by this weird "bond removal" stuff. Food for thought.
More importantly, missing a couple of license headers
| @@ -0,0 +1,21 @@ | |||
| """ | |||
Comment on lines
16
to
19
| In many cases, fuel performance is coupled with neutronic analysis as well, | ||
| because the fission gases are strong neutron absorbers. In some reactors, | ||
| significant composition changes during irradiation can influence neutronics | ||
| as well (e.g. sodium thermal bond being squeezed out of pins. |
There was a problem hiding this comment.
This is pretty SFR-specific. We may want to throw a bone to LWR folks. Maybe even mention CRUD/CIPS, even though we have yet to define parameters for them?
It is even possible that the types of parameters that an LWR fuel performance person is interested in are completely different from what an SFR person is interested in. We may want to discuss this somewhere.
| @@ -0,0 +1,15 @@ | |||
| """ | |||
…e fuel performance plugin overview to apply more generally.
youngmit
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the other generic plugins, this will be a central place
to put settings, parameters, executers, etc. that are expected to
be shared across a variety of fuel performance plugins.