Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix applyInputParams bug when values are zero #425

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Fix applyInputParams bug when values are zero #425

merged 1 commit into from
Sep 28, 2021

Conversation

keckler
Copy link
Member

@keckler keckler commented Sep 28, 2021

See #424

@keckler keckler mentioned this pull request Sep 28, 2021
Closed
john-science
john-science approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clear and easy-to-understand solution to a defined problem, and I like the light-weight touch of the solution.

@john-science
Copy link
Member

Let's start adding unit tests when we do PRs.

I know they aren't exciting work. But if the problem a PR fixes was important enough to have a discussion and a bug fix PR, it's probably important enough for a single unit test in the repo, right?

(Side Note: I'm just pushing unit tests because our code coverage is still a bit low.)

@john-science john-science merged commit 5729a29 into terrapower:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-science john-science john-science approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keckler @john-science