Fix to saving lattice map using the Grids GUI #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from the Grids GUI. This fixes a bug introduced in terrapower#440.
jakehader
commented
Nov 30, 2021
|
@ntouran is going to work on a unit test for this and I will add to it. |
This test fails with code from terrapower#440 but passes given the fix associated with this PR.
john-science
approved these changes
Dec 1, 2021
jakehader
force-pushed
the
revertgrids
branch
from
e6b7539
to
4d09dd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to writing the lattice map as a string when saving the core map from the Grids GUI. This fixes a bug introduced in #440.