Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug where SettingsModifier was using old settings API #500

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Fixed bug where SettingsModifier was using old settings API #500

merged 1 commit into from
Dec 1, 2021

Conversation

john-science
Copy link
Member

The Settings class no longer has a .get() method, we use cs['thing'] or cs.getSetting('thing') now. This class was not tested, so it passed the recent settings changes without being modified.

@john-science john-science added the bug Something is wrong: Highest Priority label Dec 1, 2021
ntouran
ntouran approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@ntouran ntouran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find and test!

@john-science john-science merged commit 9eaa6dc into terrapower:master Dec 1, 2021
@john-science john-science deleted the fix_param_sweeps branch December 1, 2021 19:26
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
@john-science @scottyak
Fixed bug where SettingsModifier was using old settings API (terrapow…
e68c6a3 
…er#500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntouran ntouran ntouran approved these changes

Assignees
No one assigned
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@john-science @ntouran