-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update key for enrichment material modification in Lithium
material class
#546
Conversation
Also deprecate the old `LI_wt_frac`
I have the same feeling about this as I did about the Thorium Oxide PR: it seems good, I wonder why this wasn't necessary before. I suppose the main concern is: do we think this will break anyone's downstream models? Perhaps we can talk about that over some sort of a call today? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Also, thanks again for the unit test coverage of the new code.
Description
The material modification keyword for enrichment in the
Lithium
material class is ambiguous to the user as to which isotope is being enriched. This is particularly confusing for the case of lithium, because 'enriched lithium' means different things to different people. People who want to use lithium as an absorber typically think 'enriched' refers to Li6, while those who use lithium in coolant materials think 'enriched' refers to Li7.In addition, the keyword is just inconsistent with all the other material classes which employ enrichment material modifications. In all other existing cases, the isotope is specified in the key.
This PR updates the key for the enrichment material modification in the
Lithium
class to avoid the ambiguity and be consistent with the other material classes.Tests have been added.
Checklist
If user exposed functionality was added/changed:
doc
folder.setup.py
.