Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unused ThermalHydraulics parameters #568

Merged
merged 2 commits into from Feb 9, 2022
Merged

Removing unused ThermalHydraulics parameters #568

merged 2 commits into from Feb 9, 2022

Conversation

john-science
Copy link
Member

Description

This PR removes some Thermal Hydraulics parameters that appear to be entirely unused, and redundant besides.

Checklist

  • The code is understandable and maintainable to people beyond the author.
  • There is no commented out code in this PR.
  • The commit message follows good practices.
  • All docstrings are still up-to-date with these changes.

@john-science john-science added the enhancement New feature or request label Feb 8, 2022
@john-science john-science merged commit dfd6c9c into master Feb 9, 2022
@john-science john-science deleted the rm_defunct_th_params branch February 9, 2022 02:50
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
@john-science @scottyak
Removing unused ThermalHydraulics parameters (terrapower#568)
abb070f 
* Removing unused ThermalHydraulics parameters

* Clarifying units of buGroups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntouran ntouran Awaiting requested review from ntouran

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@john-science