Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added holed rectangle, square, and renamed module shapes #57

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Added holed rectangle, square, and renamed module shapes #57

merged 2 commits into from
Apr 16, 2020

Conversation

onufer
Copy link
Member

@onufer onufer commented Apr 15, 2020

No description provided.

@onufer onufer requested a review from ntouran April 15, 2020 23:40
ntouran
ntouran requested changes Apr 16, 2020
View reviewed changes
Copy link
Member

@ntouran ntouran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just requesting another name

armi/reactor/components/complexShapes.py Show resolved Hide resolved
armi/reactor/components/componentCategories.py Outdated Show resolved Hide resolved
@ntouran
Copy link
Member

ntouran commented Apr 16, 2020

Oh and is it hard to boost the coverage from negative to positive with this?

@onufer
Copy link
Member Author

onufer commented Apr 16, 2020

Oh and is it hard to boost the coverage from negative to positive with this?

Yeah, I can add a few tests for area calculation of holed components.

@ntouran ntouran merged commit 19e22d2 into master Apr 16, 2020
@ntouran ntouran deleted the holedRectangle branch April 16, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntouran ntouran ntouran requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@onufer @ntouran