Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing assembly number issue in DB Load #615

Merged
merged 16 commits into from
Apr 19, 2022
Merged

Fixing assembly number issue in DB Load #615

merged 16 commits into from
Apr 19, 2022

Commits on Mar 10, 2022

  1. Update the known assembly number on DB load? 

    It seems asymmetric that this is done in `loadState()` by not `load()`.  

Though the stack trace present in the ticket did not immediately point me to this solution. So this solution needs unit tests. And I should find a DB to test with before and after this change.
    @john-science
    john-science committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    28689a0 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. This passes - whoops

    @john-science
    john-science committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    dff0977 View commit details
    Browse the repository at this point in the history

  2. Fixing black formatting

    @john-science
    john-science committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    31645e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. Playing with tests

    @john-science
    john-science committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    3c236c5 View commit details
    Browse the repository at this point in the history

  2. Adding global keyword warning to docs

    @john-science
    john-science committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    991da77 View commit details
    Browse the repository at this point in the history

  3. TODO - making a note

    @john-science
    john-science committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    6efd677 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Removing Block.makeUnique

    @john-science
    john-science committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    dcdd5cf View commit details
    Browse the repository at this point in the history

  2. Grabbing fix for black linter

    @john-science
    john-science committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    c4995a6 View commit details
    Browse the repository at this point in the history

  3. Houston, we have a solution

    @john-science
    john-science committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    d18bd7d View commit details
    Browse the repository at this point in the history

  4. Merging with master branch

    @john-science
    john-science committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    0c596c5 View commit details
    Browse the repository at this point in the history

  5. Cleaning up comments

    @john-science
    john-science committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    f9fb6f0 View commit details
    Browse the repository at this point in the history

  6. Filling out testing for this issue

    @john-science
    john-science committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    4c037bb View commit details
    Browse the repository at this point in the history

  7. Flushing out DB load tests a little

    @john-science
    john-science committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    e1ded28 View commit details
    Browse the repository at this point in the history

  8. A little more cleanup

    @john-science
    john-science committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    0812b5f View commit details
    Browse the repository at this point in the history

  9. Removing unused code - also, broken code.

    @john-science
    john-science committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    2b27e3f View commit details
    Browse the repository at this point in the history

  10. Adding a little code coverage

    @john-science
    john-science committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    c9ee54f View commit details
    Browse the repository at this point in the history