Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip auto DEPLETABLE if flags set explicitly on Component blueprint #70

Merged
merged 1 commit into from
May 8, 2020
Merged

Skip auto DEPLETABLE if flags set explicitly on Component blueprint #70

merged 1 commit into from
May 8, 2020

Conversation

youngmit
Copy link
Contributor

@youngmit youngmit commented May 8, 2020

Explicitly-defined component flags should override the behavior that automatically adds DEPLETABLE to components with depletable nuclides.

@youngmit youngmit requested a review from ntouran May 8, 2020 00:12
ntouran
ntouran approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@ntouran ntouran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call.

@youngmit youngmit merged commit b0368f5 into master May 8, 2020
@youngmit youngmit deleted the mty/autoDepletable branch June 25, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntouran ntouran ntouran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@youngmit @ntouran