Fix the hex orientation of pin locations. #730
Conversation
ntouran
force-pushed
the
fix-pin-orientation
branch
2 times, most recently
from
3b19d60
to
656bce4
Compare
| # note that it's the pointed end of the cell hexes that are up (but the | ||
| # macro shape of the pins forms a hex with a flat top fitting in the assembly) | ||
| grid = grids.HexGrid.fromPitch( | ||
| self.getPinPitch(cold=True), numRings=0, pointedEndUp=True |
There was a problem hiding this comment.
Is this still working if a user puts into their layout blueprint the geom: hex_corners_up option?
I can't quite tell myself, but it feels like maybe in that case you should set pointedEndUp=False?
There was a problem hiding this comment.
it only works on flat side up cases, you're right. I added a note in the docstring to the effect. It's be nice to detect that situation and throw an error, but we don't currently have a good way to look at a grid and determine which 'orientation' it is at this level.
There was a problem hiding this comment.
we don't currently have a good way to look at a grid and determine which 'orientation'
Sad trombone noises.
There was a problem hiding this comment.
Found this researching #1284
|
@ntouran |
The pin locations in a hex block were rotated 30 degrees from where they should be. This was discovered when plotting pin-level assembly plots and they were all sticking out the edges. The major confusion comes in from the fact that even though pointed end up doesn't seem right when you look at the pins, if you look at the little outline hexes surrounding each pin then you can see that indeed the pointed end is supposed to be up in this case. This could impact results for anyone using auto-generated pin-level grids and using the pin-wise pin coordinates.
After fixing the bug, I noticed that this other method was basically duplicated and out of date. I updated it to be consistent with the spatialLocators.
Fix formatting.
ntouran
force-pushed
the
fix-pin-orientation
branch
from
32bd1e5
to
951c1ee
Compare
The pin locations in a hex block were rotated 30 degrees from where they should be. This was discovered when plotting pin-level assembly plots and they were all sticking out the edges. The major confusion comes in from the fact that even though pointed end up doesn't seem right when you look at the pins, if you look at the little outline hexes surrounding each pin then you can see that indeed the pointed end is supposed to be up in this case. This could impact results for anyone using auto-generated pin-level grids and using the pin-wise pin coordinates.
The pin locations in a hex block were rotated 30 degrees from where they
should be. This was discovered when plotting pin-level assembly plots
and they were all sticking out the edges. The major confusion comes in
from the fact that even though pointed end up doesn't seem right when
you look at the pins, if you look at the little outline hexes
surrounding each pin then you can see that indeed the pointed end is
supposed to be up in this case.
This could impact results for anyone using auto-generated pin-level
grids and using the pin-wise pin coordinates.
Before:
After:
Checklist
If user exposed functionality was added/changed:
docfolder.