Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1D block converter to prevent negative area components. #775

Merged
merged 3 commits into from Jul 19, 2022

Conversation

jakehader
Copy link
Member

Description

The HexComponentsToCylConverter class is updated in this to properly handle and check for
negative area components after the conversion has occurred. This is a scenario that was previously
not handled and can occur when the user implements a block design in the blueprints where
two solid components are connected with a "gap-like" component and then have overlaps due
to thermal expansion. This "gap-like" component can be named anything and can either have
Void or some Liquid material type. Void components explicitly named "gap" are already handled
correctly, but that logic was not sufficient to also handle negative area components in edge modeling
cases.


Checklist

  • The code is understandable and maintainable to people beyond the author.
  • Tests have been added/updated to verify that the new or changed code works.
  • There is no commented out code in this PR.
  • The commit message follows good practices.
  • All docstrings are still up-to-date with these changes.

If user exposed functionality was added/changed:

  • Documentation added/updated in the doc folder.
  • New or updated dependencies have been added to setup.py.

@jakehader jakehader requested a review from ntouran July 16, 2022 06:49
@jakehader jakehader added the bug Something is wrong: Highest Priority label Jul 16, 2022
@jakehader
Copy link
Member Author

Hi @john-science - I added a unit test to confirm the behavior of treating negative area components on the 1D conversion process.

@john-science john-science merged commit 2be48d3 into main Jul 19, 2022
@john-science john-science deleted the blockConverters branch July 19, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants