Update 1D block converter to prevent negative area components. #775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
HexComponentsToCylConverter
class is updated in this to properly handle and check fornegative area components after the conversion has occurred. This is a scenario that was previously
not handled and can occur when the user implements a block design in the blueprints where
two solid components are connected with a "gap-like" component and then have overlaps due
to thermal expansion. This "gap-like" component can be named anything and can either have
Void
or someLiquid
material type.Void
components explicitly named "gap" are already handledcorrectly, but that logic was not sufficient to also handle negative area components in edge modeling
cases.
Checklist
If user exposed functionality was added/changed:
doc
folder.setup.py
.