Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Code Coverage Database3 #814

Merged
merged 5 commits into from
Aug 4, 2022

Conversation

john-science
Copy link
Member

@john-science john-science commented Aug 4, 2022

Description

We have been having some code coverage spray, in that certain lines in our code are covered (or not) semi-randomly when the unit tests are run.

That makes trusting our code coverage for a given PR harder.

So, I am permanently adding some code coverage to one such offending line (I think, perhaps, the last such line in our test):

https://coveralls.io/builds/51401612/source?filename=armi%2Fbookkeeping%2Fdb%2Fdatabase3.py#L1313

EDIT: I also threw in some extra code coverage and test cleanup in this PR. Sorry. The purpose of this PR is still to fix the spray on that one line above, but since I was already in the tests, I couldn't help myself.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added cleanup Code/comment cleanup: Low Priority testing Related to tests labels Aug 4, 2022
Copy link
Member

@albeanth albeanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions @john-science ! Hopefully this helps alleviate the (seemingly) random code coverage failures in CI.

I just have one simple comment to remove the declaration of an unused class variable.

armi/utils/tests/test_plotting.py Show resolved Hide resolved
@john-science john-science merged commit aa16faa into terrapower:main Aug 4, 2022
@john-science john-science deleted the code_cov_20220804 branch August 4, 2022 22:38
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority testing Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants