Specifying both Tk and Tc is an error #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A ValueError is now raised if getTc, getTk, or getTf are not given exactly one argument. This prevents unexpected behavior such as `sodium.density(Tc=100, Tk=100)` being a valid call.
Calling Sodium.thermalConductivity with the Tc argument (and no Tk argument) resulted in an error.
scottyak
pushed a commit
to scottyak/armi
that referenced
this pull request
Oct 27, 2022
* A ValueError is now raised if getTc, getTk, or getTf are not given exactly one argument. This prevents unexpected behavior such as `sodium.density(Tc=100, Tk=100)` being a valid call. * Fixed bug in Sodium.thermalConductivity (closes terrapower#858) * Calling Sodium.thermalConductivity with the Tc argument (and no Tk argument) resulted in an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it an error to specify both
TkandTcparameters to material properties routines. This is intended to prevent unexpected behavior such assodium.density(200, 300)being a valid call (the second argument is silently ignored). Unit tests have also been added to test thegetTk,getTc, andgetTffunctions in theutils.unitsmodule.Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.