Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing HT9 density - to match reference #863

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

john-science
Copy link
Member

Description

For some reason, the density of HT9 did not match the listed reference density: https://www.osti.gov/biblio/1506477-metallic-fuels-handbook (page 194/210)


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added the bug Something is wrong: Highest Priority label Aug 29, 2022
@john-science john-science linked an issue Aug 29, 2022 that may be closed by this pull request
@jakehader
Copy link
Member

Thanks @john-science! I'm not sure the impact of downstream applications so maybe we can hold off on merging until we check this?

@john-science
Copy link
Member Author

Thanks @john-science! I'm not sure the impact of downstream applications so maybe we can hold off on merging until we check this?

Agreed. Yeah, that's a bit of a concern.

On the one hand, the downstream projects would be slightly wrong, and this would be an improvement. On the other hand, I don't like surprising people.

@john-science
Copy link
Member Author

Okay, we are ready to merge this into ARMI.

It appears we have solved our downstream concerns.

@john-science john-science merged commit 9cb79cf into terrapower:main Sep 6, 2022
@john-science john-science deleted the fix_ht9_density branch September 6, 2022 21:41
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy with source and density in armi/materials/ht9.py::HT9
3 participants