-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated coveragerc file #923
Conversation
@john-science My history is a little mucked up from the interactive rebase. Working on fixing |
4e82ae9
to
9c1aba2
Compare
Hey @john-science What happened with CI? Is there a way to kick it back off without making, e.g., an empty commit? |
I think making an empty / trivial commit is the only way that I can see to easily kick off the CI again for GitHub. There isn't an easy "rerun all" since we have different GitHub actions that get fired off in parallel. That is my recommendation, but maybe @john-science has a more elegant solution. |
The coverage drop would be expected, since I added coverage-related code that can't be unit tested. |
armi/cases/case.py
Outdated
covFile = os.path.join(covRcDir, "coveragerc") | ||
else: | ||
covFile = os.path.join(covRcDir, ".coveragerc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me like you could make this simpler:
if platform...
if makeCopy...
# Make ...
covFile = os.path.join(covRcDir, ".coveragerc")
It just looks like that else
is unnecessary, and you could have the covFile =
line once instead of twice. Right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love removing the old cruft in the system!
Thanks!
* Remove extra covrc file and update case.py to handle the active file * Fix _getCovRcFile to only make copy for cov.start * Add test * Release notes * Add PROJECT_ROOT variable in context.py * Address reviewer comment, sort of, with better if statement
Description
There was a stale copy of a coverage config file in
armi/resources
. It's existence was only dreamed up to prevent the issues with dot-files on a Windows cluster. I changed the coverage work incase.py
to copy the main coverage config file to a file name without a dot instead. Voila! No more forgetting to maintain multiple files.Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.