Add writer style option to SettingsWriter pt2 : Propagate to additional methods #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the point this is happening and being processed, clone doesn't know about the "old" filepath, just the destination. Need to finish fixing.
The medium write style requires clone to pass in knowledge about the "from" location, not just the "to" location, so that the original settings can be read in. This was mostly done in the previous commit, but this commit fixes the errored path determination in writeToYamlFile.
opotowsky
force-pushed
the
add_writer_style_pt2
branch
from
cc16b01
to
5c88615
Compare
keckler
approved these changes
Oct 10, 2022
…line under the if statement it pertains to
scottyak
pushed a commit
to scottyak/armi
that referenced
this pull request
Oct 27, 2022
…al methods (terrapower#932) * Add settingsWriteStyle arg to case and suite cloning CLI/modules * WIP add unit tests * Docstring fixes * Fix for using clone with medium write style The medium write style requires clone to pass in knowledge about the "from" location, not just the "to" location, so that the original settings can be read in. * Add a test for clone * Adding a little more to writeInputs test * Release notes * Missed a commit in interactive rebase...this fixes what was missing * Address reviewer comment: add comments to explain expected test results * Address reviewer comments: More descriptive docstrings, and moving a line under the if statement it pertains to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This propagates the writing style argument to
cloneandwriteInputs(as well as the related CLI forclone).Sorry about the history. I was working on this branch in parallel to other branches.
I'll clean it up in the squash n merge.Edit: working on cleaning it up via an interactive rebaseChecklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.