Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for a reactor to be loaded without setting its cs to the master #944

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

keckler
Copy link
Member

@keckler keckler commented Oct 18, 2022

Description

When loading a reactor from a DB, it has been the default behavior to apply the associated CS to be the "master" CS for the run. This is not always desirable. Just because you load a reactor doesn't mean you want to apply it to the entire run. This small PR simply allows for that possibility.

This is related, but not actively working against, #930 .


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

Copy link
Member

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this. But:

  1. I will have to remember to remove this when I remove getMasterCs() and setMasterCs(). Though, I will be fairly busy until Halloween, so sure.
  2. Since this feature is being removed, I'm not sure we need the release notes.

@keckler
Copy link
Member Author

keckler commented Oct 18, 2022

Yeah, its in the checklist for #930 already. So should be good to go wrt remembering.

@john-science john-science merged commit 5462344 into terrapower:main Oct 19, 2022
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
@keckler keckler deleted the load-setMasterCs branch November 24, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants