Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing getMasterCs from getMicroSuffix #951

Merged
merged 3 commits into from Oct 26, 2022
Merged

Conversation

john-science
Copy link
Member

Description

In reference to Issue #930, this is a minor rewrite of getMicroSuffix() intended to help us remove one of the last 6 calls to getMasterCs() in ARMI.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added the enhancement New feature or request label Oct 25, 2022
@john-science
Copy link
Member Author

@opotowsky I don't see any reason this would affect our downstream projects. But I have not tested it thoroughly downstream, yet.

armi/reactor/blocks.py Outdated Show resolved Hide resolved
@john-science
Copy link
Member Author

Okay, I added a unit test to cover the three major cases in getMicroSuffix(). And that fixed the code coverage problem.

@opotowsky
Copy link
Member

@opotowsky I don't see any reason this would affect our downstream projects. But I have not tested it thoroughly downstream, yet.

I also don't see any reason it would impact anything. I'll be on the lookout, but don't see any reason to not merge once approved

@john-science john-science merged commit 490aee0 into main Oct 26, 2022
@john-science john-science deleted the micro_suffix_bu_group branch October 26, 2022 15:29
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants