Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserPlugins can't define Parameters #967

Merged
merged 1 commit into from Nov 19, 2022
Merged

UserPlugins can't define Parameters #967

merged 1 commit into from Nov 19, 2022

Conversation

john-science
Copy link
Member

Description

Based on the discussion in ticket #939, I did some research and found the obvious truth that UserPlugins can't (at least yet) define parameters.

Essentially, when we armi.Configure(MyApp()), we get the full set of Parameters from the ARMI App(). THEN, optionally, must later, we can read in a Settings file, that might include a UserPlugin. And at that point, it's just too late to define a Parameter. This is, I'm sure, fixable. But it would demand a high-level re-design of how and when we read plugins and parameters in ARMI.

This has always been a limit of my UserPlugin design. But no one had ever tested it before.

Due to Level-of-Effort, I think it makes more sense to leave this as a limitation of UserPlugins, and anyone who needs this much power should just use a regular ArmiPlugin.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@john-science john-science added documentation Improvements or additions to documentation cleanup Code/comment cleanup: Low Priority labels Nov 17, 2022
@john-science
Copy link
Member Author

@drewejohnson @ntouran Just FYI.

Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the work was accomplished in the discussion, so I can't speak to that fully, but I certainly approve of the implementation!

@john-science john-science merged commit da4a184 into main Nov 19, 2022
@john-science john-science deleted the user_plugin_limit branch November 19, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants