UserPlugins can't define Parameters #967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the discussion in ticket #939, I did some research and found the obvious truth that
UserPlugin
s can't (at least yet) define parameters.Essentially, when we
armi.Configure(MyApp())
, we get the full set ofParameter
s from the ARMIApp()
. THEN, optionally, must later, we can read in a Settings file, that might include aUserPlugin
. And at that point, it's just too late to define aParameter
. This is, I'm sure, fixable. But it would demand a high-level re-design of how and when we read plugins and parameters in ARMI.This has always been a limit of my
UserPlugin
design. But no one had ever tested it before.Due to Level-of-Effort, I think it makes more sense to leave this as a limitation of
UserPlugin
s, and anyone who needs this much power should just use a regularArmiPlugin
.Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.