Remove MPI barriers in TemporaryDirectoryChanger and Output cache. #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These utilities aren't always used in a way that has all MPI nodes synced up. For example if worker x has 3 tasks and worker y has 5, that could lead to a deadlock if they use these utilities. Rather than requiring all clients of these utlities know the MPI global state, we just remove the barriers, and will deal with file lock issues in more forgiving ways. Closes #982
ntouran
commented
Nov 18, 2022
armi/utils/tests/test_pathTools.py
Outdated
| @@ -26,6 +26,7 @@ | |||
| from armi.utils.directoryChangers import TemporaryDirectoryChanger | |||
|
|
|||
| THIS_DIR = os.path.dirname(__file__) | |||
| MPI_COMM = context.MPI_COMM | |||
john-science
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
The code looks good to me!
But I will need @onufer to test if this code solves his bug downstream.
|
problem is solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These utilities aren't always used in a way that has all MPI nodes synced up. For example if worker x has 3 tasks and worker y has 5, that could lead to a deadlock if they use these utilities. Rather than requiring all clients of these utlities know the MPI global state, we just remove the barriers, and will deal with file lock issues in more forgiving ways.
Closes #982
Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.