Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add energy group structure for ANL21 and ANL94 used in photon transport #994

Merged
merged 19 commits into from
Nov 24, 2022
Merged

Add energy group structure for ANL21 and ANL94 used in photon transport #994

merged 19 commits into from
Nov 24, 2022

Conversation

keckler
Copy link
Member

@keckler keckler commented Nov 23, 2022

Description

This just adds another typical energy group structure to our physics.neutronics.energyGroups module. The added structure is common for photon transport.

Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

keckler and others added 17 commits August 3, 2022 20:41
@keckler
Lookup nuclides in the ISOTXS based on their nuclide labels
7439a46
@keckler
Add tests on getReactionRates and getReactionRateDict
bf5c629
@keckler
Add to the changelog
8e6d110
@keckler
Merge branch 'terrapower:main' into main
3491057
@keckler
Merge branch 'main' of https://github.com/terrapower/armi
e30afaa
@keckler
Merge branch 'main' of https://github.com/keckler/armi
3008c03
@keckler
Merge branch 'main' of https://github.com/terrapower/armi
1b28757
@keckler
Merge branch 'terrapower:main' into main
6ce53ae
@keckler
Merge branch 'terrapower:main' into main
921a48d
@keckler
Merge branch 'main' of https://github.com/terrapower/armi
1b006b7
@keckler
Merge branch 'main' of https://github.com/keckler/armi
414b3fd
@keckler
Merge branch 'main' of https://github.com/terrapower/armi
acf3364
@keckler
Merge branch 'terrapower:main' into main
ea53fb1
@keckler
Merge branch 'main' of https://github.com/keckler/armi
615739f
@keckler
Merge branch 'main' of https://github.com/terrapower/armi
4c82111
@keckler
Add group structure for ANL21 used in photon transport
e717a52
@keckler
Update release notes
ec65566
@jakehader
Copy link
Member

Thanks @keckler - can you add the ANL94 group for photons too?

@keckler
Copy link
Member Author

keckler commented Nov 23, 2022

@jakehader Sure, done!

jakehader
jakehader requested changes Nov 23, 2022
View reviewed changes
Copy link
Member

@jakehader jakehader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numbers look correct! Minor comment.

armi/physics/neutronics/energyGroups.py Outdated Show resolved Hide resolved
armi/physics/neutronics/energyGroups.py Outdated Show resolved Hide resolved
@keckler
Copy link
Member Author

keckler commented Nov 23, 2022

@jakehader Names are fixed.

@jakehader jakehader changed the title Add energy group structure for ANL21 used in photon transport Add energy group structure for ANL21 and ANL94 used in photon transport Nov 24, 2022
@jakehader jakehader merged commit 469b3f0 into terrapower:main Nov 24, 2022
@keckler keckler deleted the photonGroups branch November 24, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakehader jakehader jakehader approved these changes

@ntouran ntouran Awaiting requested review from ntouran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keckler @jakehader