Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rails] Truncate Story filter select options in new CMS #822

Closed
rudokemper opened this issue Oct 3, 2022 · 1 comment · Fixed by #836
Closed

[Rails] Truncate Story filter select options in new CMS #822

rudokemper opened this issue Oct 3, 2022 · 1 comment · Fixed by #836
Labels
beginner friendly Good for newcomers Hacktoberfest Hacktoberfest 2023 rails

Comments

@rudokemper
Copy link
Member

The new Terrastories CMS (accessed at /member/) adds a new filter tool for filtering through Stories.

Currently, the three select boxes for this filter tool for Place and Speaker are populated by the names from records in these two models, and depending on the length of the names, the select boxes can grow quite large, and could result in undesired overflow of the filter tool past the screen width.

Let's truncate the length of the names that are shown in these boxes to 30 characters.

image

@lauramosher
Copy link
Contributor

The CSS for this uses "max-content" to dictate the width. Clearly that is not ideal.

Let's instead use a fixed width instead or a min-content with min-width. Truncating the actual names could cause confusion or remove useful information when filtering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner friendly Good for newcomers Hacktoberfest Hacktoberfest 2023 rails
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants