allow underlines for connections

terrastruct · Feb 15, 2024 · da4f626 · da4f626
1 parent 4c845ed
commit da4f626
Show file tree

Hide file tree

Showing 7 changed files with 573 additions and 0 deletions.
diff --git a/d2exporter/export.go b/d2exporter/export.go
@@ -345,6 +345,9 @@ func toConnection(edge *d2graph.Edge, theme *d2themes.Theme) d2target.Connection
 	if edge.Style.Bold != nil {
 		connection.Bold, _ = strconv.ParseBool(edge.Style.Bold.Value)
 	}
+	if edge.Style.Underline != nil {
+		connection.Underline, _ = strconv.ParseBool(edge.Style.Underline.Value)
+	}
 	if theme != nil && theme.SpecialRules.Mono {
 		connection.FontFamily = "mono"
 	}

diff --git a/d2renderers/d2svg/d2svg.go b/d2renderers/d2svg/d2svg.go
@@ -588,6 +588,9 @@ func drawConnection(writer io.Writer, labelMaskID string, connection d2target.Co
 		} else if connection.Italic {
 			fontClass += "-italic"
 		}
+		if connection.Underline {
+			fontClass += " text-underline"
+		}
 		if connection.Fill != color.Empty {
 			rectEl := d2themes.NewThemableElement("rect")
 			rectEl.X, rectEl.Y = labelTL.X, labelTL.Y

diff --git a/e2etests/testdata/txtar.txt b/e2etests/testdata/txtar.txt
@@ -164,3 +164,9 @@ monsters: {
 }
 
 costumes.monster -> monsters.id
+
+-- connection-underline --
+
+a -> b: hi {
+  style.underline: true
+}
diff --git a/e2etests/testdata/txtar/connection-underline/dagre/board.exp.json b/e2etests/testdata/txtar/connection-underline/dagre/board.exp.json
diff --git a/e2etests/testdata/txtar/connection-underline/dagre/sketch.exp.svg b/e2etests/testdata/txtar/connection-underline/dagre/sketch.exp.svg